Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log "expected" websocket errors #1024

Merged
merged 3 commits into from
Feb 24, 2016
Merged

Don't log "expected" websocket errors #1024

merged 3 commits into from
Feb 24, 2016

Conversation

paulbellamy
Copy link
Contributor

Fixes #1019

Upgrading gorilla/websocket also makes the logging a bit nicer for the other errors.

@tomwilkie
Copy link
Contributor

Do we also want this in app/controls.go:82 and app/pipes.go:44?

@paulbellamy
Copy link
Contributor Author

We don't actually do anything with those errors, so...

@tomwilkie
Copy link
Contributor

Can you look into:

<app> INFO: 2016/02/24 15:39:53.980948 err: websocket: close 1005 (no status)
<app> INFO: 2016/02/24 15:39:56.828722 err: websocket: close 1005 (no status)
<app> INFO: 2016/02/24 15:40:22.730329 err: websocket: close 1005 (no status)
<app> INFO: 2016/02/24 15:40:25.486719 err: websocket: close 1005 (no status)
<app> INFO: 2016/02/24 15:40:27.203276 err: websocket: close 1005 (no status)

Happens when you change topologies in the UI.

Otherwise LGTM.

@paulbellamy paulbellamy force-pushed the 1019-websocket-error-logging branch from afee0d1 to f794bbf Compare February 24, 2016 16:25
@paulbellamy
Copy link
Contributor Author

Turns out 1005 is also a valid websocket closing. It just means the other end sent a close frame with no reason specified.

paulbellamy added a commit that referenced this pull request Feb 24, 2016
@paulbellamy
Merge pull request #1024 from weaveworks/1019-websocket-error-logging
6b9daa7 
Don't log "expected" websocket errors
@paulbellamy paulbellamy merged commit 6b9daa7 into master Feb 24, 2016
@paulbellamy paulbellamy deleted the 1019-websocket-error-logging branch February 24, 2016 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbellamy @tomwilkie